WIP: Make occurrence check match paper occurrence filtering better.#35
Merged
WIP: Make occurrence check match paper occurrence filtering better.#35
Conversation
mdales
added
🏗️ enhancement
mdales
force-pushed
the
mwd-better-dahal-occurrence
branch
from
7f586d5 to
f544505
Compare
mdales
commented
Nov 12, 2025
| .vscode/ | ||
|
|
||
| # Claude Code | ||
| .claude/ No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
@shaneweisz had you removed this in your last PR? Not sure how this got added to mine - I wonder if it's from the merge conflict I had to do
Collaborator
There was a problem hiding this comment.
I think I added it in my last PR. Perhaps got removed accidentally during the merge conflict – I do think it makes sense to have it in the .gitignore like you've done 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still need to fix the unit tests on this, but it now matches the dahal paper much more closely.
FYI @shaneweisz